Fixing slow joins to post_read, post_saved, and comment_saved . #2738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dessalines
commented
Feb 15, 2023
dessalines
commented
- Fixes Show read posts setting is timing out front page. #2445
dessalines
commented
Feb 15, 2023
| @@ -365,17 +365,17 @@ impl<'a> PostQuery<'a> { | |||
| }; | |||
|
|
|||
| if self.saved_only.unwrap_or(false) { | |||
| query = query.filter(post_saved::id.is_not_null()); | |||
There was a problem hiding this comment.
I hate SQL sometimes. Even though the join comes back null, and shouldn't even really have to check any column, it did anyway. Changing this to one of the joinable columns made it run instantly.
dessalines
commented
Feb 15, 2023
| @@ -325,7 +325,7 @@ impl<'a> CommentQuery<'a> { | |||
|
|
|||
| if self.local_user.is_some() { | |||
| // Filter out the rows with missing languages | |||
| query = query.filter(local_user_language::id.is_not_null()); | |||
There was a problem hiding this comment.
Went through all these null and not_null checks, and made sure they all worked on one of the columns that was joined to.
dessalines
commented
Feb 15, 2023
docker/dev/docker-compose.yml
Outdated
| @@ -97,7 +97,8 @@ services: | |||
| "postgres", | |||
| "-c", "session_preload_libraries=auto_explain", | |||
| "-c", "auto_explain.log_min_duration=5ms", | |||
| "-c", "auto_explain.log_analyze=true" | |||
| "-c", "auto_explain.log_analyze=true", | |||
| "-c", "track_activity_query_size=1048576" | |||
There was a problem hiding this comment.
SQL truncates results for some reason on the pg_stat queries without this.
dessalines
commented
Feb 15, 2023
| @@ -0,0 +1,2 @@ | |||
| create index idx_post_saved_person_id on post_saved (person_id); | |||
| create index idx_comment_saved_person_id on comment_saved (person_id); | |||
There was a problem hiding this comment.
Should speed up the saved queries a bit.
Nutomic
approved these changes
Feb 18, 2023
|
Should be fine but has conflicts. |
Nutomic
pushed a commit
that referenced
this pull request
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.