Tweaking postgres upgrade script #2389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
reviewed
Aug 4, 2022
scripts/postgres_12_to_14_upgrade.sh
Outdated
| @@ -2,19 +2,20 @@ | |||
| set -e | |||
|
|
|||
| ## This script upgrades the postgres from version 12 to 14 | |||
There was a problem hiding this comment.
You could also change all the comments to echo instead. Anyway there is no reason to say the same thing in a comment, and echo it right below, like below with "export the db".
Nutomic
approved these changes
Aug 4, 2022
dessalines
force-pushed
the
fix_upgrade_script
branch
from
d474641
to
0b45c7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.