Use typed-builder crate for queries #2379
Conversation
|
Damn nice, had no idea something like that existed. |
| ) | ||
| } else { | ||
| (posts_query.build().list()?, comments_query.build().list()?) | ||
| }; |
There was a problem hiding this comment.
This is pretty ugly but i dont see a better way, because the builder type changes when a setter is called. So the previous mut solution doesnt work.
There was a problem hiding this comment.
You could also do creator_id(None) I spose for those cases, but its not necessary. That's dissapointing, because one of the points of builder pattern is to be able to set things conditionally before you build. Oh well.
There was a problem hiding this comment.
There is another builder macro which should support is, but disadvantage is that it doesnt get checked at compile time, and build() returns a result. Thats probably why this conditional isnt working.
|
Generally whenever the same impl is copy-pasted for many different structs, that code can instead be generated with a derive macro. The PR is finished, but tests are failing and i cant tell why. There dont seem to be any logic changes in relevant code. |
Nutomic
changed the title
|
The commentreport and postreport order is coming back incorrectly. |
| my_person_id: PersonId, | ||
| #[builder(!default)] |
There was a problem hiding this comment.
These are just mandatory fields that probably shouldn't have a default.
| community_id: None, | ||
| page: None, | ||
| limit: None, | ||
| unresolved_only: Some(true), |
There was a problem hiding this comment.
Found it, i didnt notice before that this is being initialized here. My change should be equivalent, and tests are passing now.
| ) | ||
| } else { | ||
| (posts_query.build().list()?, comments_query.build().list()?) | ||
| }; |
There was a problem hiding this comment.
You could also do creator_id(None) I spose for those cases, but its not necessary. That's dissapointing, because one of the points of builder pattern is to be able to set things conditionally before you build. Oh well.
| fn get_optional(self) -> Option<T> { | ||
| self | ||
| } | ||
| } |
There was a problem hiding this comment.
Thx for getting rid of these, they're pointless now with this.
Only trying this out for now. If this looks good, i will also implement it for PostQuery, CommentQuery etc, after changes to those files are merged. Should shorten the code significantly.
https://crates.io/crates/typed-builder