Fix follow being stuck as pending after accept #2366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
approved these changes
Jul 19, 2022
|
The current lemmy-js-client handles it, check the drone log: https://cloud.drone.io/LemmyNet/lemmy/3894 |
|
The test is wrong. It can never see a status of pending, because tests use synchronous sending, so during the followCommunity api call, the accept is also sent and handled before the api call returns. And follow_accepted() gets called when Accept activity is received, so its not pending anymore. Meaning pending has to be set to false. |
dessalines
force-pushed
the
fix-follow-pending
branch
from
6185eb6 to
ea02b34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix it, though i couldnt test properly because lemmy-ui 0.16.5 cant handle the new subscribed values.