Add cargo feature for building lemmy_api_common with mininum deps #2243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
added a commit
that referenced
this pull request
May 5, 2022
Nutomic
added a commit
that referenced
this pull request
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it possible to build only lemmy_api_common, without pulling in any of the heavy dependencies like diesel. Useful for building a Lemmy client while using the exact same structs for serde. I was mainly trying to minimize the usage of conditional compilation, but in the end there was still a lot of it necessary.
https://doc.rust-lang.org/cargo/reference/features.html
Times for
cargo build -p lemmy_api_common:before: 2m 46s
after: 32s