Federation: dont overwrite local object from Announce activity #2232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
commented
Apr 21, 2022
| /// When for example a Post is made in a remote community, the community will send it back, | ||
| /// wrapped in Announce. If we simply receive this like any other federated object, overwrite the | ||
| /// existing, local Post. In particular, it will set the field local = false, so that the object | ||
| /// can't be fetched from the Activitypub HTTP endpoint anymore (which only serves local objects). |
There was a problem hiding this comment.
This comment explains whats going wrong.
|
I cant figure out why locked status isnt federating properly. Its even weirder because tests fail at unlock, but with manual testing i cant even get lock to federate. Or rather, it seems to federate fine, but gets restored to the previous status for some reason. |
|
Damn, i didnt set ap_id and so it was creating a new post in the database for every federated lock action. |
dessalines
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing something else and came across a way to reproduce the problem in #2143.