Friendica federation #2167
Merged
Friendica federation #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
force-pushed
the
friendica-federation
branch
from
afd5593
to
eb7f53b
Compare
dessalines
reviewed
Mar 28, 2022
| @@ -1,44 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
Did you mean to delete all these ones that don't have anything to do with friendica?
There was a problem hiding this comment.
Yes, check the second commit. Basically, these objects are already being tested as part of Create/Note and similar activity tests, so there is no real reason to add them twice. Except maybe to figure out what exactly isnt working, so maybe better to keep them. Now i'm not sure myself.
There was a problem hiding this comment.
IMO it would make sense to keep them, if only for the reason that they individually might add / remove things in the future, and these separate files are a place to keep track of that.
| @@ -44,42 +44,33 @@ mod tests { | |||
| #[test] | |||
| fn test_parse_objects_pleroma() { | |||
| test_json::<Person>("assets/pleroma/objects/person.json").unwrap(); | |||
| test_json::<Note>("assets/pleroma/objects/note.json").unwrap(); | |||
Nutomic
force-pushed
the
friendica-federation
branch
from
eb7f53b
to
3c56816
Compare
|
updated |
Nutomic
force-pushed
the
friendica-federation
branch
2 times, most recently
from
3c56816
to
e9b2f62
Compare
dessalines
approved these changes
Mar 29, 2022
dessalines
force-pushed
the
friendica-federation
branch
from
e9b2f62
to
1f00f56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.