Check that config is valid before saving #2152
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that you can currently set a config that is completely invalid (eg wrong braces), and Lemmy will happily save it, reload the config and then stop working. This adds a simple check to make sure that the config can be parsed before saving.
There are also some other problems with updating the config like this:
couldnt_update_site
. Would be good if this could be more specific, eg indicating that the given config is invalid (and in which place), or that the file is not writable.deser-hjson
crate.System::exit()
insave_config_file()
, but it didnt seem to work. Would be good to mention in lemmy-ui that a restart is necessary.