Implement instance actor #1798

Nutomic · 2021-09-28T16:09:34Z

This will allow us to federate things like instance description and site bans. It is also a prerequisite for #1487.

Todo:

write db migrations
fetch the instance actor when parsing a remote community (make it optional if possible for compatibility)
implement site inbox/outbox
create api for retrieving info for remote instances
write federation test

Nutomic · 2022-02-01T21:17:55Z

This is almost finished, just need to get the api tests working and do some manual testing. There are no breaking changes, so we can simply release it in 0.15.3

api_tests/src/shared.ts

Nutomic · 2022-02-01T21:28:23Z

crates/api_common/src/community.rs

+  /// default values. May be null if the community is hosted on an older Lemmy version, or on
+  /// another software.
+  /// TODO: this should probably be SiteView
+  pub site: Option<Site>,


I wasnt sure whats the best way to expose this data over the api. Anyway its not needed for federated bans, so i can just remove it and implement it properly later. The main purpose is to show the instance sidebar (with rules etc) when browsing a remote community.

dessalines · 2022-02-02T14:57:54Z

Tests failing for some reason.

Nutomic · 2022-02-07T13:44:52Z

Fixed api tests. Also removed site from GetCommunityResponse, because it was badly implemented. We should do that later, so that the sidebar/rules of remote instance can be displayed when browsing a remote community.

So this is ready to review/merge/release.

dessalines

Looks good, my only thing is due to the changes in the site table that will require additions to lemmy-js-client, and possibly apps, that we merge but push this to the next release. Also it'll need some testing.

My main question and what we need to test: This will only federate the bans and removes from the host instance, correct?

IE if enterprise bans and removes content from someone that lives on ds9, the deletes and bans should not be federated to DS9.

But if the user lives on enterprise, then that ban and deletes should be federated elsewhere.

dessalines · 2022-02-07T15:54:57Z

crates/apub/src/activities/block/block_user.rs

+        verify_domains_match(&site.actor_id(), self.actor.inner())?;
+        verify_domains_match(&site.actor_id(), self.object.inner())?;
+      }
+      SiteOrCommunity::Community(community) => {


We don't have to worry about this in this PR, but something tells me there's a better / more generic way to do these SiteOrCommunity and PostOrComment enums, maybe @asonix has some ideas.

if you don't want to keep re-defining two-variant enums you could use a single Either<L, R> type instead

crates/apub/src/http/site.rs

crates/apub/src/objects/comment.rs

dessalines · 2022-02-07T16:04:41Z

crates/apub/src/protocol/collections/empty_outbox.rs

 #[derive(Clone, Debug, Deserialize, Serialize)]
 #[serde(rename_all = "camelCase")]
-pub(crate) struct PersonOutbox {
+pub(crate) struct EmptyOutbox {


Whats going on here.

Just changed the name, because this is used both by Person and Site now. So the old name wouldnt make much sense. Only functionality change is how the outbox url is generated (because site does that differently).

crates/apub/src/protocol/mod.rs

dessalines · 2022-02-07T16:08:05Z

crates/db_schema/src/impls/site.rs

+  pub fn read_remote_sites(conn: &PgConnection) -> Result<Vec<Self>, Error> {
+    use crate::schema::site::dsl::*;
+    site.order_by(id).offset(1).get_results::<Self>(conn)


Nice, I like this, it'll be useful for other things.

crates/db_schema/src/source/site.rs

dessalines · 2022-02-07T16:16:07Z

migrations/2022-01-28-104106_instance-actor/up.sql

+    add column last_refreshed_at Timestamp not null default now(),
+    add column inbox_url varchar(255) not null default generate_unique_changeme(),
+    add column private_key text,
+    add column public_key text not null default generate_unique_changeme();


looks good.

crates/api_crud/src/site/create.rs

Nutomic · 2022-02-07T17:02:46Z

My main question and what we need to test: This will only federate the bans and removes from the host instance, correct?

IE if enterprise bans and removes content from someone that lives on ds9, the deletes and bans should not be federated to DS9.

But if the user lives on enterprise, then that ban and deletes should be federated elsewhere.

Correct, site bans are only federated if they are made on the user's home instance. Actually i forgot to check for that, but added the check now.

I dont think additional fields are considered a breaking change, as they are generally ignored. And if not, that would be easy enough to change in the client.

dessalines · 2022-02-07T17:30:15Z

Correct, site bans are only federated if they are made on the user's home instance. Actually i forgot to check for that, but added the check now.

Could you also add a federation test for that? Seems important to make sure admins can't mess with other instances.

Nutomic · 2022-02-07T18:08:26Z

Such a test wouldnt be effective. As you can see in my second to last commit, the activity isnt even sent when its a remote user. The same is true with most other malicious activites, Lemmy prevents sending them (but other software still can).

So to test for that, we would need another test suite that eliminates the sending Lemmy instance from the equation. The easiest way would be to store activities as json files in the repo, and POST them to Lemmy directly with curl, then check that the expected action was (not) taken.

* Implement instance actor * wip: make site bans federate * finish implementation and unit tests for federated bans * start adding api tests * fix api test * remve site from GetCommunityResponse * only federate site bans originating from user's home instance * dont expose site.private_key in api

Nutomic marked this pull request as draft September 28, 2021 16:09

Nutomic force-pushed the instance-actor branch 2 times, most recently from 311200b to eac0348 Compare September 30, 2021 17:56

Nutomic mentioned this pull request Oct 1, 2021

Remove site.creator_id #1808

Closed

Nutomic force-pushed the instance-actor branch 7 times, most recently from b8daa56 to 4b0dbdf Compare February 1, 2022 21:16

Nutomic force-pushed the instance-actor branch from 4b0dbdf to d7a9584 Compare February 1, 2022 21:18

Nutomic commented Feb 1, 2022

View reviewed changes

api_tests/src/shared.ts Show resolved Hide resolved

Nutomic force-pushed the instance-actor branch from d7a9584 to e7a0675 Compare February 1, 2022 21:27

Nutomic commented Feb 1, 2022

View reviewed changes

Nutomic marked this pull request as ready for review February 1, 2022 21:35

Nutomic requested a review from dessalines as a code owner February 1, 2022 21:35

Nutomic force-pushed the instance-actor branch from e7a0675 to 9e3fbae Compare February 7, 2022 13:39

Nutomic force-pushed the instance-actor branch from 94e7ae3 to 02eee1c Compare February 7, 2022 13:45

dessalines approved these changes Feb 7, 2022

View reviewed changes

Nutomic force-pushed the instance-actor branch from 38481b9 to 238dc11 Compare February 7, 2022 16:57

Nutomic added 3 commits February 7, 2022 14:10

Implement instance actor

95ac570

wip: make site bans federate

136e1ae

finish implementation and unit tests for federated bans

760027a

Nutomic added 5 commits February 7, 2022 14:10

start adding api tests

d206e8a

fix api test

3da2804

remve site from GetCommunityResponse

52ce279

only federate site bans originating from user's home instance

1b4998e

dont expose site.private_key in api

0dad9a6

dessalines force-pushed the instance-actor branch from 6e56ce0 to 0dad9a6 Compare February 7, 2022 19:10

dessalines enabled auto-merge (squash) February 7, 2022 19:10

dessalines merged commit dd865c5 into main Feb 7, 2022

Nutomic mentioned this pull request Apr 12, 2022

Display sidebar of remote instance #2208

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement instance actor #1798

Implement instance actor #1798

Nutomic commented Sep 28, 2021 •

edited

Loading

Nutomic commented Feb 1, 2022

Nutomic Feb 1, 2022

dessalines commented Feb 2, 2022

Nutomic commented Feb 7, 2022 •

edited

Loading

dessalines left a comment

dessalines Feb 7, 2022

asonix Feb 7, 2022

dessalines Feb 7, 2022

Nutomic Feb 7, 2022

dessalines Feb 7, 2022

dessalines Feb 7, 2022

Nutomic commented Feb 7, 2022

dessalines commented Feb 7, 2022

Nutomic commented Feb 7, 2022

Implement instance actor #1798

Implement instance actor #1798

Conversation

Nutomic commented Sep 28, 2021 • edited Loading

Nutomic commented Feb 1, 2022

Nutomic Feb 1, 2022

Choose a reason for hiding this comment

dessalines commented Feb 2, 2022

Nutomic commented Feb 7, 2022 • edited Loading

dessalines left a comment

Choose a reason for hiding this comment

dessalines Feb 7, 2022

Choose a reason for hiding this comment

asonix Feb 7, 2022

Choose a reason for hiding this comment

dessalines Feb 7, 2022

Choose a reason for hiding this comment

Nutomic Feb 7, 2022

Choose a reason for hiding this comment

dessalines Feb 7, 2022

Choose a reason for hiding this comment

dessalines Feb 7, 2022

Choose a reason for hiding this comment

Nutomic commented Feb 7, 2022

dessalines commented Feb 7, 2022

Nutomic commented Feb 7, 2022

Nutomic commented Sep 28, 2021 •

edited

Loading

Nutomic commented Feb 7, 2022 •

edited

Loading