Rewrite fetcher #1792
Merged
Rewrite fetcher #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
commented
Sep 24, 2021
| @@ -135,7 +135,8 @@ test('Update a post', async () => { | |||
| test('Sticky a post', async () => { | |||
| let postRes = await createPost(alpha, betaCommunity.community.id); | |||
|
|
|||
| let stickiedPostRes = await stickyPost(alpha, true, postRes.post_view.post); | |||
| let betaPost1 = (await resolvePost(beta, postRes.post_view.post)).post; | |||
| let stickiedPostRes = await stickyPost(beta, true, betaPost1.post); | |||
There was a problem hiding this comment.
This was wrong, alpha is not a mod and shouldnt be able to make a post sticky. It only worked due to a bug in the apub fetcher which is fixed now.
There was a problem hiding this comment.
Alpha is an admin, and I just checked the server code, admins should be able to sticky.
There was a problem hiding this comment.
Admin on instance alpha, but not on beta. So the sticky wont federate.
Nutomic
commented
Sep 24, 2021
Nutomic
force-pushed
the
rewrite-fetcher
branch
from
732f119 to
24fc616
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are all internal changes in the apub crate, and shouldnt affect the behaviour (except for bug fixes). The code is much cleaner now, and doesnt implement the same logic multiple times. This is also necessary so that we can move it to the library later.