Add additional slurs configuration option. Closes #1464. #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to additional regex for slurs filtering. It can be done through `additional_slurs` option in config file.
ba1ash
force-pushed
the
feature/1464-additional-slurs
branch
from
9e78f9c
to
07e5640
Compare
ba1ash
changed the title
|
Sry I've been slow on this, I'll get to it shortly. |
dessalines
reviewed
May 26, 2021
Comment on lines
+93
to
+96
| # additional_slurs: | ||
| # ''' | ||
| # (\bThis\b)|(\bis\b)|(\bsample\b) | ||
| # ''' |
There was a problem hiding this comment.
The heredoc makes sense here I think, although hjson might be able to handle everything after the : fine.
dessalines
approved these changes
May 26, 2021
Nutomic
approved these changes
May 26, 2021
|
Thanks @ba1ash! |
Nutomic
pushed a commit
that referenced
this pull request
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings!
Implemented #1464.
Without a test :( I don't know how to test this gracefully. I don't like the idea of config file modification at runtime. Maybe it's okay to fill in
additional_slursoption by default with some slurs and rely on them in test.If someone has a suggestion about the proper test implementation I will be happy to implement it :)