Add some fallback properties for display in older browsers #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 24, 2021 18:49
dessalines
reviewed
Jan 3, 2022
Comment on lines
+115
to
116
| display: inline-grid; | ||
| display: inline-flex; |
There was a problem hiding this comment.
This doesn't seem like valid css, could you do display: inline-flex inline-grid.
And what browser doesn't support flex?
There was a problem hiding this comment.
This doesn't seem like valid css,
Apparently it is...?
could you do display: inline-flex inline-grid.
Well, when doing fallback code, apparently the fallback should be put first, than the current code under it...
And what browser doesn't support flex?
This is a very minor use-case yes, but the one SailfishOS uses as it's default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.