Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix allowed and blocked instances not being fetched for admin settings #1627

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

SleeplessOne1917
Copy link
Member

Closes #1621

Copy link
Contributor

@alectrocute alectrocute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a normal Inferno pattern (using deepEqual for comparing props on lifecycle hooks) that we’ll need to adapt everywhere else eventually, too?

@SleeplessOne1917
Copy link
Member Author

Is this a normal Inferno pattern...

No clue. Documentation and learning materials for inferno are pretty sparse. I think the need for this is due to doing too much in some of our components though.

@dessalines dessalines enabled auto-merge (squash) June 27, 2023 12:07
@dessalines dessalines merged commit 34188eb into main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allowed and blocked instances are broken in lemmy-ui 0.18.0
3 participants