Correct error messages if user registers with taken user/email #3093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
force-pushed
the
duplicate-signup-errors
branch
4 times, most recently
from
71c5bf1 to
01a352a
Compare
dessalines
reviewed
Jun 15, 2023
crates/api_crud/src/user/create.rs
Outdated
| @@ -111,28 +118,12 @@ impl PerformCrud for Register { | |||
| let local_user_form = LocalUserInsertForm::builder() | |||
| .person_id(inserted_person.id) | |||
| .email(data.email.as_deref().map(str::to_lowercase)) | |||
| .password_encrypted(data.password.to_string()) | |||
| .password_encrypted(hash(&data.password, DEFAULT_COST)?) | |||
There was a problem hiding this comment.
Seems fine to move this up, but I hope you tested.
There was a problem hiding this comment.
This wasnt working after all, because it also needs to hash the setup password defined in config file. Reverted the change.
| pub async fn is_email_taken(pool: &DbPool, email_: &str) -> Result<bool, Error> { | ||
| let conn = &mut get_conn(pool).await?; | ||
| let count = local_user | ||
| .filter(email.eq(email_)) |
There was a problem hiding this comment.
Just use exists: https://docs.diesel.rs/master/diesel/dsl/fn.exists.html
Nutomic
force-pushed
the
duplicate-signup-errors
branch
2 times, most recently
from
71a3824 to
a1ce1f2
Compare
dessalines
approved these changes
Jun 20, 2023
Nutomic
force-pushed
the
duplicate-signup-errors
branch
from
397f1b3 to
5f9c7af
Compare
Nutomic
force-pushed
the
duplicate-signup-errors
branch
from
5f9c7af to
5d70a9f
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2955