-
-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1884 - Support Spoiler Tags #3018
Conversation
…m rule to manage spoiler blocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
AFAIK this will only affect RSS feeds and some federated objects. The lemmy UIs just receive pure markdown, so they have to have do their own markdown parsers. I still have yet to add some of this stuff into kotlin / jerboa.
FYI this will affect RSS feeds, emails, and federation (except with other Lemmy instances in which case the markdown source is used). Nothing else I think. |
@Nutomic @dessalines Thanks for the initial reviews; made some changes based on your feedback. LMK what you think! |
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This change is causing issues since markdown-it panics in some cases which breaks feeds and federation. See also #3411 and markdown-it-rust/markdown-it#26 Edit: I also want to mention since this is not mentioned anywhere: This seems to "just" be a subset of |
Looks like the maintainer confirmed that this is a bug in upstream, not related to this change. |
WHAT & WHY
Adds support for managing spoiler blocks by:
markdown-it
library used by the UI and, more importantly, supports adding and creating custom plugins.comrak
nor another potentially performant librarypulldown-cmark
do not appear to have any support for plugins so the library switch is necessary.This is my first time writing in Rust, so apologies for any obvious semantic mistakes 🙏