Force enable undetermined language #2851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
reviewed
May 11, 2023
|
|
||
| // No need to update if languages are unchanged | ||
| let current = LocalUserLanguage::read(pool, for_local_user_id).await?; | ||
| if current == lang_ids { | ||
| return Ok(()); | ||
| } | ||
|
|
||
| // HACK: Force enable undetermined language for all users. This is necessary because many posts |
There was a problem hiding this comment.
Add TODO, that makes it easier to grep, since we already have a lot of those.
dessalines
approved these changes
May 12, 2023
Nutomic
force-pushed
the
force-enable-undetermined-lang
branch
from
cb360c4 to
716e4de
Compare
Nutomic
added a commit
that referenced
this pull request
May 19, 2023
* Force enable undetermined language * update * fix tests
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables undetermined language for all existing users, and also enables it whenever the user language is updated. This is necessary because many posts don't have a language tag (e.g. those from other federated platforms), so Lemmy users won't see them if undetermined language is disabled. This hack can be removed once a majority of posts have language tags, or when it is clearer for new users that they need to enable undetermined language.
I think we should include this in 0.17.3
By the way I noticed that the user language selection in lemmy-ui at /settings seems to be broken in latest dev version (Firefox). The
xbutton does nothing so its not possible to clear the selection and select other languages. Also "undetermined" is not shown in enabled languages even when it is returned by Lemmy API.