Fixing empty req issue. #2849
Merged
Fixing empty req issue. #2849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this a problem with websocket, http or both? If only websocket then you should leave a comment to remove these fields after we remove the websocket api. |
|
HTTP actually. The rust backend for some reason can't deserialize a |
Nutomic
approved these changes
May 11, 2023
|
Thats odd, maybe its because of our wrapper structs. I guess after removing websocket we can get rid of them, and also remove this hack. |
Nutomic
pushed a commit
that referenced
this pull request
May 19, 2023
* Fixing empty req issue. * Forgot skip serializing none.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this issue when adding lemmy-ui support for
GetFederatedInstances.Unfortunately, due to some peculiarities with our http and websocket code, request objects can not be empty / null / empty null unit structs. We have only two, and adding an optional auth fixes it.