Fixing broken websockets. #2770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
reviewed
Feb 28, 2023
src/api_routes_websocket.rs
Outdated
| @@ -299,7 +302,7 @@ pub async fn match_websocket_operation_crud( | |||
| context: LemmyContext, | |||
| id: ConnectionId, | |||
| op: UserOperationCrud, | |||
| data: &str, | |||
| data: &Value, | |||
There was a problem hiding this comment.
Cant you pass this by value (without &) and avoid using clone? I think it should work by calling get() and then take().
There was a problem hiding this comment.
Got it, using .cloned() worked.
There was a problem hiding this comment.
Cloned is the same as clone, it still copies data around unnecessarily.
Nutomic
approved these changes
Feb 28, 2023
dessalines
added a commit
that referenced
this pull request
Apr 26, 2023
* Fixing broken websockets. * Use cloned() for serde::Value
Nutomic
pushed a commit
that referenced
this pull request
Apr 27, 2023
* Fixing broken websockets. * Use cloned() for serde::Value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrongly didn't test websockets with one of my recent PRs, this fixes it. It also removes a pointless to and from string conversion for the json data.