Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide comment view under /comment/123 #1919

Closed
Nutomic opened this issue Nov 18, 2021 · 3 comments
Closed

Provide comment view under /comment/123 #1919

Nutomic opened this issue Nov 18, 2021 · 3 comments

Comments

@Nutomic
Copy link
Member

Nutomic commented Nov 18, 2021

This address is linked when a Lemmy comment is shown in other software, eg Mastodon or Pleroma. At the moment, clicking on it will lead to a 404 page. We should provide a comment view under that address, or at least a redirect to the existing /post/123/comment/123 url.

See #1912 for details.

@dessalines
Copy link
Member

We don't currently have a GetComment in the API, because I wanted that to be a little more advanced, IE show things like context, show child comments, etc. Like so:

image

Two options:

@Nutomic
Copy link
Member Author

Nutomic commented Nov 18, 2021

Serverside comment trees are probably still some time away, right? So a simple GetComment endpoint seems like a good solution for now.

@dessalines
Copy link
Member

Yeah I could do that without too much difficulty.

@dessalines dessalines transferred this issue from LemmyNet/lemmy-ui Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants