Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont announce comments, edited posts to Pleroma/Mastodon followers #1914

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

Nutomic
Copy link
Member

@Nutomic Nutomic commented Nov 18, 2021

It was mentioned that the current Lemmy behaviour of announcing all new and edited posts/comments to Pleroma and Mastodon followers might be too noisy. So here is a PR which changes it so that only new posts are announced to them. For us this doesnt make a difference, as we are specifically sending these activities for compatibility with Mastodon/Pleroma.

Note that these users wont receive any comments from Lemmy then, unless it is a mention. Lemmy also doesnt provide a replies collection on posts or comments for the time being. So let me know what you prefer @lanodan @Gargron @ClearlyClaire.

@Nutomic Nutomic marked this pull request as draft November 18, 2021 15:30
@ClearlyClaire
Copy link

I do think not boosting comments would indeed match more closely to what most Mastodon users expect.

As for getting replies to Mastodon, currently, Mastodon has limited support for forwarding replies by forwarding the activity itself when it has a Linked-Data Signature. Note however that not all implementations use Linked-Data Signatures, and Mastodon can be configured not to either, so it's not a full solution either. So far, Mastodon has not focused on getting all replies from remote posts it is interested in, so there is not really any other mechanism yet. As proper support for groups is on the roadmap, this may change in the future, though.

@Nutomic Nutomic marked this pull request as ready for review November 19, 2021 16:48
@dessalines dessalines merged commit 6d35508 into main Nov 19, 2021
Nutomic added a commit that referenced this pull request Nov 19, 2021
dessalines added a commit that referenced this pull request Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants