Move code to apub library #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready to merge, even though the macro code is quite ugly. Edit: maybe not, a lot more work to be done here. |
Nutomic
force-pushed
the
apub-lib-changes
branch
from
432a21f to
ba0c79f
Compare
Nutomic
force-pushed
the
apub-lib-changes
branch
from
ba0c79f to
968cd0b
Compare
|
Updated, see op. Now its really ready to merge. |
Nutomic
changed the title
Nutomic
force-pushed
the
apub-lib-changes
branch
from
968cd0b to
d3a3cf0
Compare
Closed
dessalines
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved a couple more things to the library (traits ApubObject, ActorType, also http signature handling and activity sending queue). This means that I had to move some trait impls into the db_schema crate (because impls can only be defined in the same crate with the struct, or in the same crate as the trait definition).
Following this, I think we can also merge the crates db_schema and db_queries again. They have to be compiled one after the other, so it doesnt help with compilation time at all to split the code this way.
There is still some apub code which needs to be moved to the library, mainly ObjectId, receive_activity(), FromApub, ToApub. I will take care of those in a later PR.