From 0bad0cb9ca5d6a40efdaf4398c4d41e3d51fb5de Mon Sep 17 00:00:00 2001 From: Thomas Brillard Date: Fri, 13 Sep 2024 10:46:21 +0200 Subject: [PATCH] feat: allow gasLimit field to be disabled (#7784) --- .changeset/swift-turtles-taste.md | 5 ++++ .../evm/SendAmountFields/GasLimitField.tsx | 27 ++++++++++--------- .../src/renderer/families/types.ts | 1 + .../renderer/modals/Send/SendAmountFields.tsx | 1 + .../Swap2/Form/FeesDrawerLiveApp/index.tsx | 1 + 5 files changed, 23 insertions(+), 12 deletions(-) create mode 100644 .changeset/swift-turtles-taste.md diff --git a/.changeset/swift-turtles-taste.md b/.changeset/swift-turtles-taste.md new file mode 100644 index 000000000000..0ee6ca376952 --- /dev/null +++ b/.changeset/swift-turtles-taste.md @@ -0,0 +1,5 @@ +--- +"ledger-live-desktop": minor +--- + +feat: allow gasLimit field to be disabled diff --git a/apps/ledger-live-desktop/src/renderer/families/evm/SendAmountFields/GasLimitField.tsx b/apps/ledger-live-desktop/src/renderer/families/evm/SendAmountFields/GasLimitField.tsx index 833255b57391..1f81fd1a8df0 100644 --- a/apps/ledger-live-desktop/src/renderer/families/evm/SendAmountFields/GasLimitField.tsx +++ b/apps/ledger-live-desktop/src/renderer/families/evm/SendAmountFields/GasLimitField.tsx @@ -17,6 +17,7 @@ const AdvancedOptions: NonNullable["component"] = transaction, status, updateTransaction, + disableEditGasLimit, }) => { invariant(transaction.family === "evm", "AdvancedOptions: evm family expected"); invariant(account, "Account required"); @@ -63,18 +64,20 @@ const AdvancedOptions: NonNullable["component"] = ) : ( - + {!disableEditGasLimit && ( + + )} )} diff --git a/apps/ledger-live-desktop/src/renderer/families/types.ts b/apps/ledger-live-desktop/src/renderer/families/types.ts index 68cf611e4126..52c13aedefe1 100644 --- a/apps/ledger-live-desktop/src/renderer/families/types.ts +++ b/apps/ledger-live-desktop/src/renderer/families/types.ts @@ -216,6 +216,7 @@ export type LLDCoinFamily< bridgePending?: boolean; trackProperties?: Record; transactionToUpdate?: T; + disableEditGasLimit?: boolean; }>; fields?: string[]; }; diff --git a/apps/ledger-live-desktop/src/renderer/modals/Send/SendAmountFields.tsx b/apps/ledger-live-desktop/src/renderer/modals/Send/SendAmountFields.tsx index d57bae884ff9..d8b956775d59 100644 --- a/apps/ledger-live-desktop/src/renderer/modals/Send/SendAmountFields.tsx +++ b/apps/ledger-live-desktop/src/renderer/modals/Send/SendAmountFields.tsx @@ -15,6 +15,7 @@ export type SendAmountFieldsProps = { trackProperties?: Record; transactionToUpdate?: Transaction; disableSlowStrategy?: boolean; + disableEditGasLimit?: boolean; }; const AmountRelatedField = (props: SendAmountFieldsProps) => { diff --git a/apps/ledger-live-desktop/src/renderer/screens/exchange/Swap2/Form/FeesDrawerLiveApp/index.tsx b/apps/ledger-live-desktop/src/renderer/screens/exchange/Swap2/Form/FeesDrawerLiveApp/index.tsx index 13671aab271f..a03755344b9a 100644 --- a/apps/ledger-live-desktop/src/renderer/screens/exchange/Swap2/Form/FeesDrawerLiveApp/index.tsx +++ b/apps/ledger-live-desktop/src/renderer/screens/exchange/Swap2/Form/FeesDrawerLiveApp/index.tsx @@ -129,6 +129,7 @@ export default function FeesDrawerLiveApp({ updateTransaction={handleUpdateTransaction} mapStrategies={mapStrategies} disableSlowStrategy={disableSlowStrategy} + disableEditGasLimit={true} trackProperties={{ page: "Swap quotes", ...swapDefaultTrack,