Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.12 raise more specific exception when entity does not exist #330

Closed
dpriskorn opened this issue May 4, 2022 · 1 comment · Fixed by #331
Closed

v0.12 raise more specific exception when entity does not exist #330

dpriskorn opened this issue May 4, 2022 · 1 comment · Fixed by #331
Assignees
@LeMyst
Labels
enhancement New feature or request v0.12.x

Comments

@dpriskorn
Copy link
Contributor

bild

WikibaseIntegrator/wikibaseintegrator/entities/baseentity.py

Line 127 in 189b102

raise ValueError('Entity is nonexistent')

I suggest a new exception EntityNonexistantError or something like that.
@LeMyst LeMyst linked a pull request May 5, 2022 that will close this issue
Add NonExistentEntityError exception #331
Merged
@LeMyst LeMyst self-assigned this May 5, 2022
@LeMyst LeMyst added v0.12.x enhancement New feature or request labels May 5, 2022
@LeMyst
Copy link
Owner

LeMyst commented May 5, 2022

Fixed in #331

@LeMyst LeMyst closed this as completed May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeMyst LeMyst

Labels
enhancement New feature or request v0.12.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add NonExistentEntityError exception LeMyst/WikibaseIntegrator
2 participants
@LeMyst @dpriskorn