Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing curl with something like ureq #612

Closed
LeonKowarschickKenbun opened this issue Jan 18, 2023 · 1 comment
Closed

Consider replacing curl with something like ureq #612

LeonKowarschickKenbun opened this issue Jan 18, 2023 · 1 comment

Comments

@LeonKowarschickKenbun
Copy link

Building tch-rs is (as expected) one of the biggest contributors to compilation time. However, I noticed that the execution of the torch-sys buildscript starts surprisingly late in the compilation graph (-> cargo build --timings), seemingly due to the curl crate and its build-script actually taking a good few seconds to build, and moving tch quite late into compilation.
By replacing curl with a smaller dependency such as ureq, I was able to improve clean build time by about 10 seconds. (Through very unscientific testing, of course, but still)

It may be worth considering such a switch. I'd be happy to contribute a PR if you think this is viable!

@LaurentMazare
Copy link
Owner

Closing this now that the change to ureq has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants