Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When installing a language laravel breeze is not detected #115

Closed
luisprmat opened this issue May 26, 2021 · 4 comments · Fixed by #116
Closed

When installing a language laravel breeze is not detected #115

luisprmat opened this issue May 26, 2021 · 4 comments · Fixed by #116
Labels
bug Something isn't working

Comments

@luisprmat
Copy link
Member

  • Lang Publisher Version: 10.0.1
  • Laravel Version: 8.43.0
  • PHP Version: 8.0.3

Description:

This program don't translate laravel breeze keys.
If i want use laravel breeze instead laravel jetstream (with fortify), the keys aren't translated

Steps To Reproduce:

  • Install a new laravel project laravel new my-project
  • cd my-project
  • Install laravel breeze composer require laravel/breeze --dev
  • run breeze command php artisan breeze:install, then npm install, npm run dev, php artisan migrate.
  • install lang-publisher composer require andrey-helldar/laravel-lang-publisher --dev
  • Set some language, for example spanish php artisan lang:add es
  • Set locale to es in config/app.php
  • Go to route register for example (This view is not translate)

i guess laravel breeze uses translations from laravel jestream and that's the reason why it doesn't work.

@andrey-helldar
Copy link
Member

I will check shortly what translations it uses and either add its definition to jetstream files (or other product) or send a PR to the laravel-lang/lang repository.

@andrey-helldar andrey-helldar added the bug Something isn't working label May 26, 2021
@andrey-helldar
Copy link
Member

One of the keys is in the fortify project.

I will prepare and submit a PR to add a file for the laravel/breeze project in laravel-lang/lang and implement support for this file in this package.

image

@andrey-helldar
Copy link
Member

PR in this project: #116
Wait for Laravel-Lang/lang#1763

@andrey-helldar andrey-helldar linked a pull request May 27, 2021 that will close this issue
@andrey-helldar
Copy link
Member

@luisprmat, as a workaround, added detection of the installed Breeze package and copying keys from jetstream and fortify.

Released in v10.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

2 participants