You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In my tests, the column links don't work 80% of the times... what do you say we remove them? 👀
I mean... the way we generate the links is unreliable... we just get the table name, create a route from it and HOPE that links exists. We will be pointing to entries who don't have CRUDs, I'm sure of it. It just depends on the project if it's 10%, 20% or 80%.
So the question is... is it better to point to broken links... or not point at all? 🤷♂️
The text was updated successfully, but these errors were encountered:
Of course... it'd be best if we could generate reliable links 😅
And for that... we could instruct people to add a new method to their ActivityLog trait:
public function getAdminPageUrl() {
return url(route(Str::of($entry->getTable())->singular().".show", ['id' => $this->getKey()]));
}
Then they can override that method in each model, if needed.
BUUT. It would still be unreliable. Because the correct place to get that information is the CrudController... where the dev has defined things in their setup().
In my tests, the column links don't work 80% of the times... what do you say we remove them? 👀
I mean... the way we generate the links is unreliable... we just get the table name, create a route from it and HOPE that links exists. We will be pointing to entries who don't have CRUDs, I'm sure of it. It just depends on the project if it's 10%, 20% or 80%.
So the question is... is it better to point to broken links... or not point at all? 🤷♂️
The text was updated successfully, but these errors were encountered: