Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Add binding to force zones to stay away for arbitrary amount of time #5910

Open
3 tasks done
zach2good opened this issue Jun 12, 2024 · 0 comments
Open
3 tasks done
Labels
core Gives visibility for reviewers for impacted areas involving cpp enhancement New feature request good first issue Good for newcomers

Comments

@zach2good
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

Describe the feature

Downstream request.

zone:setKeepalive(utils.minutes(15)) or similar.

Currently we keep zones alive for 5 seconds or so after the last player exits before it goes to sleep. This binding would take whatever mechanism that is and set it to be an arbitrary timestamp that defaults to be "time the last player left" + 5 seconds, where the 5 seconds can be overridden temporarily. Once the zone goes to sleep, that time will be reset to the default and will need to be set again if you want a higher timer.

This is thought of as TEMPORARY!

In an ideal world the keep-alive-ness of zones will be managed exclusively from the world server, where it'll send "wake up" and "go to sleep" messages, but our RPC systems in both C++ and Lua land are hard to use and fragile.

Once they're enhanced or replaced with gRPC or something gRPC-like, with a layer of Lua bindings on top, then we can do away with these arbitrary timers.

@zach2good zach2good added enhancement New feature request good first issue Good for newcomers core Gives visibility for reviewers for impacted areas involving cpp labels Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Gives visibility for reviewers for impacted areas involving cpp enhancement New feature request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant