Build error on raspberry pi 5.

[Totien]

Hello all. I am attempting to build on a raspberry pi 5, but I'm getting the following error. I'm not too savvy on debugging build errors, so hoping someone can help.

I have removed the build directory and started over. It always fails at the same spot.

user@pym-lab:~/FFXI/server/build $ make -j $(nproc)
[ 0%] Built target bcrypt
[ 4%] Built target Recast
[ 4%] Built target fmt
[ 4%] Built target fast_obj_lib
[ 6%] Built target Detour
[ 11%] Built target efsw
[ 13%] Built target spdlog
[ 17%] Built target efsw-static
[ 17%] Built target DetourTileCache
[ 18%] Built target DetourCrowd
[ 18%] Built target DebugUtils
[ 32%] Built target mariadbclientcpp
[ 42%] Built target xi_search
[ 42%] Built target xi_connect
[ 48%] Built target xi_world
[ 48%] Building CXX object src/map/CMakeFiles/xi_map.dir/lua/luautils.cpp.o
[ 48%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/conquest_map.cpp.o
[ 48%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/cs_position.cpp.o
[ 49%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/currency1.cpp.o
[ 49%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/currency2.cpp.o
[ 49%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/delivery_box.cpp.o
[ 49%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/downloading_data.cpp.o
/home/user/FFXI/server/src/map/lua/luautils.cpp: In lambda function:
/home/user/FFXI/server/src/map/lua/luautils.cpp:841:28: error: comparison is always true due to limited range of data type [-Werror=type-limits]
841 | if ((c >= 0 && c <= 0x20) || c >= 0x7F)
| ~~^~~~
[ 49%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/entity_animation.cpp.o
[ 50%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/entity_enable_list.cpp.o
[ 50%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/entity_set_name.cpp.o
[ 50%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/entity_update.cpp.o
[ 50%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/entity_visual.cpp.o
[ 50%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/event.cpp.o
[ 50%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/event_string.cpp.o
[ 51%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/event_update.cpp.o
[ 51%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/event_update_string.cpp.o
[ 51%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/fishing.cpp.o
[ 51%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/fish_ranking.cpp.o
[ 51%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/furniture_interact.cpp.o
[ 51%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/guild_menu.cpp.o
[ 52%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/guild_menu_buy.cpp.o
[ 52%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/guild_menu_buy_update.cpp.o
[ 52%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/guild_menu_sell.cpp.o
[ 52%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/guild_menu_sell_update.cpp.o
[ 52%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/independent_animation.cpp.o
[ 52%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/instance_entry.cpp.o
[ 53%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/inventory_assign.cpp.o
[ 53%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/inventory_count.cpp.o
[ 53%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/inventory_finish.cpp.o
[ 53%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/inventory_item.cpp.o
[ 53%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/inventory_modify.cpp.o
[ 54%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/inventory_size.cpp.o
[ 54%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/jobpoint_details.cpp.o
[ 54%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/jobpoint_update.cpp.o
[ 54%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/key_items.cpp.o
[ 54%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/linkshell_equip.cpp.o
[ 54%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/linkshell_message.cpp.o
[ 55%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/lock_on.cpp.o
[ 55%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/macroequipset.cpp.o
[ 55%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/map_marker.cpp.o
[ 55%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/menu_config.cpp.o
[ 55%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/menu_jobpoints.cpp.o
[ 55%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/menu_merit.cpp.o
[ 56%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/menu_mog.cpp.o
[ 56%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/menu_raisetractor.cpp.o
[ 56%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/merit_points_categories.cpp.o
[ 56%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/menu_unity.cpp.o
[ 56%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/message_basic.cpp.o
[ 56%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/message_combat.cpp.o
[ 57%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/message_name.cpp.o
[ 57%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/message_special.cpp.o
[ 57%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/message_standard.cpp.o
[ 57%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/message_system.cpp.o
[ 57%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/message_text.cpp.o
[ 57%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/monipulator1.cpp.o
[ 58%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/monipulator2.cpp.o
[ 58%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/party_define.cpp.o
[ 58%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/party_effects.cpp.o
[ 58%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/party_invite.cpp.o
[ 58%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/party_map.cpp.o
[ 59%] Building CXX object src/map/CMakeFiles/xi_map.dir/packets/party_member_update.cpp.o
cc1plus: all warnings being treated as errors
make[2]: *** [src/map/CMakeFiles/xi_map.dir/build.make:1517: src/map/CMakeFiles/xi_map.dir/lua/luautils.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:1072: src/map/CMakeFiles/xi_map.dir/all] Error 2
make: *** [Makefile:156: all] Error 2

[melinko2003]

Try this:
https://github.com/melinko2003/xltd-ffxi/blob/main/.github/workflows/build-executables.yml#L59

export CC=/usr/bin/gcc-14
export CXX=/usr/bin/g++-14
sed -i 's/if ((c >= 0 && c <= 0x20) || c >= 0x7F)/if (!std::isprint(static_cast<unsigned char>(c)))/' src/map/lua/luautils.cpp
if [ $(uname -p) = "x86_64" ]; then CFLAGS=-m64 CXXFLAGS=-m64 LDFLAGS=-m64 cmake -S . -B build ; fi
if [ $(uname -p) = "aarch64" ]; then cmake -S . -B build ; fi

It's all Arm64 from what I've seen. I'm guessing GCC or the compilers on Arm64 don't appreciate unsigned chars.

[zach2good]

I refactored that condition out of the code so you should be able to compile past it, but I don't have any guarantees you won't hit another snag: #6973