reraise behavior

[TeoTwawki]

While looking into a recent pr and determining our reraise menu is dropped and does not return after cs events (such as when being kicked out of a battlefield) I got to talking with Xaver about an old pet peeve of mine: rare situations in which reraise will strip your reraise and that menu from being zoned.

While the PR was to fix the loss on battlefield exit (there was a bit of confusion as the PR author said "zoning") I proposed not caring about retails behavior in regard to being zoned:

I say we just keep rr always till a choice is made, leave a design doc stating we chose it on purpose

This is what I wish to discuss here.

By keep rr I mean the menu - the status effect is lost when you die. Anytime retail stripped my reraise menu was a throw-the-controller moment for me. We should retain it till a choice is made.

The current open PR may do exactly this. I can't say if its best method or not, at the time the PR was in need of a rebase. We did determine that our battlefield exit wasn't tripping a zone, just a cs+pos change for the exit mechanic.

A consideration is going to be thorough testing to ensure we do not return previously fixed reraise bugs. Sending an incorrect time value or sending 2 packets too close together where one of them has an incorrect timer value will auto trigger a homepoint regardless of player input.

[Xaver-DaRed]

I personally see this as an example of a "be better than retail" acceptable deviation.