diff --git a/packages/playwright/src/smartui.js b/packages/playwright/src/smartui.js index 42f2088..dee3068 100644 --- a/packages/playwright/src/smartui.js +++ b/packages/playwright/src/smartui.js @@ -2,10 +2,10 @@ const utils = require('@lambdatest/sdk-utils'); const pkgName = require('../package.json').name; // Take a DOM snapshot and post it to the snapshot endpoint -async function smartuiSnapshot(page, snapshotName, options) { +async function smartuiSnapshot(page, name, options) { if (!page) throw new Error('A Playwright `page` object is required.'); - if (!snapshotName) throw new Error('The `name` argument is required.'); - if (!(await utils.isSmartUIRunning())) throw new Error('SmartUI server is not running.'); + if (!name || typeof name !== 'string') throw new Error('The `name` argument is required.'); + if (!(await utils.isSmartUIRunning())) throw new Error('Cannot find SmartUI server.'); let log = utils.logger(pkgName); @@ -25,11 +25,11 @@ async function smartuiSnapshot(page, snapshotName, options) { let { body } = await utils.postSnapshot({ dom, url: page.url(), - name: snapshotName, + name, options }, pkgName); - log.info(`Snapshot captured: ${snapshotName}`); + log.info(`Snapshot captured: ${name}`); if (body && body.data && body.data.warnings?.length !== 0) body.data.warnings.map(e => log.warn(e)); } catch (err) { diff --git a/packages/puppeteer/src/smartui.js b/packages/puppeteer/src/smartui.js index 8a4a598..4072d36 100644 --- a/packages/puppeteer/src/smartui.js +++ b/packages/puppeteer/src/smartui.js @@ -4,8 +4,8 @@ const pkgName = require('../package.json').name; async function smartuiSnapshot(page, name, options = {}) { if (!page) throw new Error('puppeteer `page` argument is required.'); - if (!name) throw new Error('The `name` argument is required.'); - if (!(await utils.isSmartUIRunning())) throw new Error('SmartUI server is not running.'); + if (!name || typeof name !== 'string') throw new Error('The `name` argument is required.'); + if (!(await utils.isSmartUIRunning())) throw new Error('Cannot find SmartUI server.'); let log = utils.logger(pkgName); diff --git a/packages/sdk-utils/src/lib/utils.js b/packages/sdk-utils/src/lib/utils.js index 1e43008..8fc031a 100644 --- a/packages/sdk-utils/src/lib/utils.js +++ b/packages/sdk-utils/src/lib/utils.js @@ -1,5 +1,6 @@ function getSmartUIServerAddress() { - return process.env.SMARTUI_SERVER_ADDRESS || 'http://localhost:8080' + if (!process.env.SMARTUI_SERVER_ADDRESS) throw new Error('SmartUI server address not found'); + return process.env.SMARTUI_SERVER_ADDRESS } module.exports = { diff --git a/packages/selenium-driver/src/smartui.js b/packages/selenium-driver/src/smartui.js index a2b3803..a2d34fc 100644 --- a/packages/selenium-driver/src/smartui.js +++ b/packages/selenium-driver/src/smartui.js @@ -4,8 +4,8 @@ const pkgName = require('../package.json').name; async function smartuiSnapshot(driver, name, options = {}) { // TODO: check if driver is selenium webdriver object if (!driver) throw new Error('An instance of the selenium driver object is required.'); - if (!name) throw new Error('The `name` argument is required.'); - if (!(await utils.isSmartUIRunning())) throw new Error('SmartUI server is not running.'); + if (!name || typeof name !== 'string') throw new Error('The `name` argument is required.'); + if (!(await utils.isSmartUIRunning())) throw new Error('Cannot find SmartUI server.'); let log = utils.logger(pkgName); try { diff --git a/packages/testcafe/src/smartui.js b/packages/testcafe/src/smartui.js index f7ecc18..3a57b2c 100644 --- a/packages/testcafe/src/smartui.js +++ b/packages/testcafe/src/smartui.js @@ -1,10 +1,10 @@ const utils = require('@lambdatest/sdk-utils'); const pkgName = require('../package.json').name; -async function smartuiSnapshot(t, snapshotName, options) { +async function smartuiSnapshot(t, name, options) { if (!t) throw new Error("The test function's `t` argument is required."); - if (!snapshotName) throw new Error('The `name` argument is required.'); - if (!(await utils.isSmartUIRunning())) throw new Error('SmartUI server is not running.'); + if (!name || typeof name !== 'string') throw new Error('The `name` argument is required.'); + if (!(await utils.isSmartUIRunning())) throw new Error('Cannot find SmartUI server.'); let log = utils.logger(pkgName); @@ -26,11 +26,11 @@ async function smartuiSnapshot(t, snapshotName, options) { let { body } = await utils.postSnapshot({ dom: dom, url, - name: snapshotName, + name, options }, pkgName); - log.info(`Snapshot captured: ${snapshotName}`); + log.info(`Snapshot captured: ${name}`); if (body && body.data && body.data.warnings?.length !== 0) body.data.warnings.map(e => log.warn(e)); } catch (error) {