Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DUNE/Hardware/LUCL: Possible buffer overflow #217

Open
tsmarques opened this issue Sep 29, 2020 · 0 comments
Open

DUNE/Hardware/LUCL: Possible buffer overflow #217

tsmarques opened this issue Sep 29, 2020 · 0 comments

Comments

@tsmarques
Copy link
Contributor

Hi,

I think this line might cause a buffer overflow?

In the lines above it we check if the data we're trying to write is smaller than 64 bytes

if (data_size > c_data_max)
    throw std::runtime_error("maximum data size exceeded");

but then the total buffer size for the message is only 32

uint8_t msg[32] = {c_sync, (uint8_t)(data_size + 1), cmd};
std::memcpy(msg + 3, data, data_size);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant