Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do we use normprof? #985

Closed
nikfilippas opened this issue Aug 19, 2022 · 0 comments · Fixed by #1043
Closed

Why do we use normprof? #985

nikfilippas opened this issue Aug 19, 2022 · 0 comments · Fixed by #1043
Labels

Comments

@nikfilippas
Copy link
Contributor

nikfilippas commented Aug 19, 2022

I don't think it is a good design choice to have to pass all the profiles and their corresponding normprof arguments in the entire halos subpackage. In practice, the profiles are either always normalized, or they aren't, for the life of the HaloProfile instance. A better design choice is to have normprof as an attribute of each profile. These can be preset, but we may give the option to users to change it if needed (even though I doubt it will ever need to change). At the end of the day, normprof has to do with an individual profile, so it makes sense for it to be an attribute of that profile.

Currently, users have to keep track of all the profiles and their normprofs with their respective numbers (normprof1, normprof2, ...) which is not only tedious, but can also be error prone.

@nikfilippas nikfilippas linked a pull request Mar 27, 2023 that will close this issue
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant