Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation on CCL MG param handling. #867

Closed
c-d-leonard opened this issue Mar 26, 2021 · 3 comments · Fixed by #1116
Closed

Improve documentation on CCL MG param handling. #867

c-d-leonard opened this issue Mar 26, 2021 · 3 comments · Fixed by #1116

Comments

@c-d-leonard
Copy link
Collaborator

c-d-leonard commented Mar 26, 2021

I'm finding that as of recently, it seems like changing the value of mu0 doesn't change the matter power spectrum. Here's a pdf of a notebook where I demonstrate that changing this parameter seems to have no effect at all on the linear matter power spectrum.
check_mg_functionality.pdf

What's going on here? mu0 should definitely change the linear matter power spectrum, right? Am I missing something big?

@damonge @mishakb any ideas?

(My project student @OSmotherly initially identified this behaviour so I'm tagging him so that he can follow.)

@c-d-leonard
Copy link
Collaborator Author

Looking into this a bit more, seems like there are at least two different questions going on here:

  • if you make a cosmology object with mu_0 != 0 and you leave the transfer_function as the default (boltzmann_camb), when you call ccl.linear_matter_power is you run through cosmo.compute_linear_power() (in core.py) which sends you to get_camb_pk_lin which happily returns the matter power spectrum ignoring MG parameters. I don't think this is the intended behaviour, I think it should naively rescale the power spectrum if not using isitgr. I'm digging more into this.
  • if you do use boltzmann_isitgr as the transfer function, it seems that the linear matter power spectrum is only altered from its GR value at very large scales (k<10^{-3}). This is not what I would expect either, I'd expect to basically match naive rescaling at intermediate scales (linear but not very very large e.g. k=10^{-3}-10^{-2} at least).

This issue seems to persist as far back as v2.0.0 (probably further but that's the first tag with MG), weirdly. I'll keep looking into it.

@mishakb
Copy link
Collaborator

mishakb commented Apr 12, 2021

thanks @c-d-leonard for bringing these questions up and I will have a look as soon as I can. I just came out of a Black Hole of work (to be mathematically correct, let's say a White Hole since outgoing geodesics are allowed then).

@c-d-leonard
Copy link
Collaborator Author

I have figured out what's going on I think, for both cases. This was originating from the fact that I was setting my cosmology in terms of sigma8 rather than A_s and then looking at P(k) at z=0. I now recall that we agreed that if a cosmology is defined in terms of sigma8 with a non-zero mu0 value we should enforce that the power spectrum at z=0 behaves as it should for the defined sigma8. If I either define in terms of A_s or look at a different redshift, I get the expected behaviour both using rescaling with camb and using isitgr.

This behaviour with cosmologies with sigma8 and mu0!=0 is not clear in the docs as far as I can see. I think the action item for this issue should probably be to fix the docs which describe the parameters / Cosmology object to note this.

@nikfilippas nikfilippas changed the title Possible MG parameters bug? Improve documentation on CCL MG param handling. Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants