Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: HazMat personnel not properly counted in extended missing vehicle table. #2052

Closed
JanSuerth opened this issue Jan 4, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@JanSuerth
Copy link
Contributor

What happened?

On the US Version the missing-vehicles alert displays missing Hazmat personnel. When "Enhanced missing vehicles" from the "Extended alarm window" module is enabled the personnel also gets displayed in the table.

When selecting a vehicle the counter for the educated hazmat personnel doesn't count people on the vehicle but rather only the hazmat vehicle (so the counter goes up by one even when "maximum staff" is enabled)

Vehicles like the Hazmat Ambulance do not get counted at all for the personnel.

Default display: https://i.imgur.com/TU5K78s.png
With enhanced missing vehicles: https://i.imgur.com/qXprl1N.png
(In both pictures there is a HazMat ambulance selected but not yet dispatched. It is staffed with 6 educated personnel and "maximum staff" is enabled for enhanced missing vehicles.

How to reproduce?

  1. extended missing vehicles needs to be enabled
  2. maximum staff needs to be enabled
  3. in a mission with missing hazmat personnel select a HazMat or HazMat ambulance

Expected behavior

I expected that the personnel of the HazMat or HazMat ambulance would be counted towards the missing personnel rather then counting the number of Hazmat vehicles selected.

System

  • OS: Windows 11
  • Browser and version: Edge - Version 108.0.1462.54 (Official build) (64-bit)
  • LSSM-Version: 4.7.2+20221226.1422 [stable]
  • Game-Version: https://www.missionchief.com/

Additional

msedge_m8DvenHE7D
tnxv0UHZTo

@JanSuerth JanSuerth added the bug Something isn't working label Jan 4, 2023
@JanSuerth JanSuerth changed the title [BUG]: [BUG]: HazMat personnel not properly counted in extended missing vehicle table. Jan 4, 2023
@Cr4zyc4k3
Copy link
Collaborator

@jxn-30 This should be fixable with a few tweaks in

or did I miss something?

@jxn-30
Copy link
Member

jxn-30 commented Jul 5, 2023

@jxn-30 This should be fixable with a few tweaks in

or did I miss something?

I don't think so. The parser will still count the text as a vehicle (there is no fully reliable way to determine for a text if it is a vehicle or a training requirement). As the texts are exactly same for HazMat vehicle and training requirement, the issue is caused.

@Cr4zyc4k3
Copy link
Collaborator

Next try: With https://forum.leitstellenspiel.de/index.php?thread/8406-infos-f%C3%BCr-entwickler/&postID=495288#post495288
we should be able to distinguish between personal, vehicles and "others"

@Cr4zyc4k3
Copy link
Collaborator

@JanSuerth Is this fixed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants