Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Unscanable QR code #303

Open
JimmyMow opened this issue Oct 27, 2019 · 6 comments
Open

Unscanable QR code #303

JimmyMow opened this issue Oct 27, 2019 · 6 comments
Labels
blocked this issue is blocked on another issue (possibly in a diff project) bug Something isn't working

Comments

@JimmyMow
Copy link
Member

Not sure if this is because my invoices are really large for some reason? But, the QR code i’m getting when generating an invoices can’t be scanned by anyone I’m with currently. Not sure what the best workaround would be, but definitely a UX bug imo
770AF017-2813-42FD-AE36-6C68CCB1FCC8

@JimmyMow
Copy link
Member Author

Ok, when testing more, I think this is because the invoice is considerably large. I assume this is because my node is huge and including a crazy amount of route hints or something?

@ottosuess
Copy link
Member

yes. there are 18 routing hints in the invoice.
lnd's api only has the option to disable routing hints completely or set custom routing hints.

no way to limit the number. what should we do? open an issue on lnd's github to request a flag max_ routing_hints to limit the number?

@ottosuess
Copy link
Member

this PR (by @Crypt-iQ 🔥) seems to have a solution: lightningnetwork/lnd#3022

@ottosuess ottosuess added blocked this issue is blocked on another issue (possibly in a diff project) bug Something isn't working labels Nov 7, 2019
@Crypt-iQ
Copy link

Crypt-iQ commented Nov 7, 2019

What's the size of the invoice in bytes? I merged a PR a while back that limited the size of an invoice to 7089 bytes lightningnetwork/lnd#3505
If yours is bigger, can definitely open up a PR to change the max.

@ottosuess
Copy link
Member

$ echo -n lightning:LNBC1M1PWMFHK6PP5NF032E6DD3G7HFZC9KG6F83C6SQ9MPHWN8UTWDQ23QEVP6FNNYGSDQQCQZPGXQRRSSRZJQGUG6U90565TEMHWVVECDTFTCE7P430W7ZH8TDK57F0L7K6ZTFQHUZXG0SQQGNQQQYQQQQLGQQQQQQGQ9QRZJQGUG6U90565TEMHWVVECDTFTCE7P430W7ZH8TDK57F0L7K6ZTFQHUZ8JR5QQRDCQQYQQQQLGQQQQQQGQ9QRZJQ2HRCPHKMD4G0658FMMM4PKG02CQG84T7MVTUPV5TQJSTV0AT4LWSZ8TLVQQX3GQQQQQQQLGQQQQQQGQ9QRZJQ2ETVKJZ5N83699LFPSQRR50LQAWYH559CGE9XMTR42RQPKJCR2AWZG7ZVQQVSSQQQQQQQLGQQQQQQGQ9QRZJQTTKRTL97TPFEVVJTLG0PU5PZJLM56N88R8VK8AJKFDRTA5KDL8K5ZFFVSQQ29QQQYQQQQLGQQQQQQGQ9QRZJQTDDX37J02Z8Z4GZLQ34454KL9CMCWQ8YR2N6TDHD3GQYZS0D42ZXZ8KRQQQVDSQQQQQQQLGQQQQQQGQ9QRZJQTDAJ2VVP6R3GVNKGSYR33XRK6KL6XPL6XWFRQW08ZJ4P34DY944ZZXZSYQQ4NCQQYQQQQLGQQQQQQGQJQRZJQVH5D50F5RQDHXW00ZXALKRDS9D7D6WH22HN0AXW7KSN55NK4ACQGZF2CQQQH9CQQQQQQQLGQQQQQQGQ9QRZJQDRCK2J36WF8HC69RM4ZHKVNQ03GUHDJ04JDKKWPF6UNGQ69RDR82ZFTHQQQSWSQQYQQQQLGQQQQQQGQ9QRZJQWVTPC0F6U83X8SCED4PT7JV2X2Y85VVKNC29PWMRUWAHN97V2VR2ZXELYQQXPGQQQQQQQLGQQQQQQGQ9QRZJQW0KVSSJWHRCEUYEJW4JVP5LQQERSAZRXFC6DYUMYK4YNE226ZR4CZ8PJVQQFMCQQQQQQQLGQQQQQQGQ9QRZJQWS7KCGU8YDHNCVLM52C5UL77MHKQ343PK05TAL9DQMVEZPNUXVFWZFYYGQQC9QQQQQQQQLGQQQQQQGQ9QRZJQWNFKFLGQ3D2CZ0ZNP8LHJL6EFHCADD6CSVKKRLC28KEQPT4CGLRGZGHY5QQS5CQQYQQQQLGQQQQQQGQ9QRZJQWKVYMRMG99WQWJWLYPMDCGCGRJXFGAC3THLL8TZLRSHW68CTUF4VZXCLSQQN4SQQQQQQQLGQQQQQQGQJQRZJQWKVN7GHDAG3KEAW6CA6QSRQRL8952M6G5SC23M8UQEWFNT37H8K2Z895QQQ8CGQQQQQQQLGQQQQQQGQ9QRZJQWMW5CA9DQ3MQ3PTT20E7V29E9DDSRT2052ZTZL0QU67KASC5KJ0CZXE4GQQGSSQQQQQQQLGQQQQQQGQ9QRZJQ0TY33DGN88PMJN8W7N8Q3NA9LWWHDGSV9L0HUWH26E2DR7SW6N97ZG8VSQQV6GQQYQQQYUGQQQQN3QQ9QRZJQ0MJ6YVRMDE4XGYY6L5JJZNCUD48J6ENGEMM9A5TCSCJME8CNKWGQZGT5UQQP5CQQYQQQQLGQQQQQQGQ9QUAVQC5HLHWW5YP5YW22F09SEKNTZRAAMUEJDA66KAT2QEAAM0TXSAE5TMCNPU85TM3LH40MZ8AAXUKWETVUZDKL5ST6EAHXNQM5VW4SP8A7V2H | wc -c
    1733

@Crypt-iQ
Copy link

Crypt-iQ commented Nov 7, 2019

Weird, do you guys me to check this one out and see if it's on lnd side? I'm updating the PR otto linked today and it might get in by 0.9 🤞

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked this issue is blocked on another issue (possibly in a diff project) bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants