Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.midi files cannot be opened from the sidebar #6400

Closed
Monospace-V opened this issue May 8, 2022 · 1 comment · Fixed by #6417
Closed

.midi files cannot be opened from the sidebar #6400

Monospace-V opened this issue May 8, 2022 · 1 comment · Fixed by #6417

Comments

@Monospace-V
Copy link
Contributor

Bug Summary

From the import dialogue, MIDI based files with extensions ".mid," ".midi," and ".rmi" can be opened. But from the sidebar, ".mid" files can be opened but ".midi" files cannot. I don't know about .rmi, though...

Steps to reproduce

  1. Download a file with extension .midi instead of .mid, like https://drive.google.com/file/d/1NqxQmdP63N711_NKFal-2lAWt7Vu39XD/view?usp=sharing
  2. Navigate to it from sidebar and attempt to import it into the project

Expected behavior

MIDI file is imported

Actual behavior

MIDI file is unusable from sidebar.

Screenshot

image

Affected LMMS versions

1.2.0, 1.3 alpha

@Monospace-V Monospace-V added the bug label May 8, 2022
@zonkmachine
Copy link
Member

@Monospace-V I think it's enough to change this

else if( ext == "mid" )

to

else if( ext == "mid" || ext == "midi" || ext == "rmi" )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants