Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get all plugins to be compataible with MSVC #5898

Closed
dan-giddins opened this issue Jan 31, 2021 · 3 comments
Closed

Get all plugins to be compataible with MSVC #5898

dan-giddins opened this issue Jan 31, 2021 · 3 comments
Assignees
@dan-giddins
Labels
compatibility windows

Comments

@dan-giddins
Copy link

Plugins are blacklisted in CMakeLists.txt. Look for MSVC_INCOMPATIBLE_PLUGINS.

tresf: Disabling ALL LADSPA plugins seems a bit overkill but was likely done as a quick solution to start MSVC work. Now that MSVC is in very good shape, we'll need to be more granular about it. This may require some CMake reworking to toggle the LasdpsaEffect folder back on and then blacklist the actually LADSPA effects one by one instead.
@dan-giddins dan-giddins self-assigned this Jan 31, 2021
@DomClark
Copy link
Member

DomClark commented Feb 5, 2021

See also #3999.

@DomClark DomClark linked a pull request Aug 20, 2023 that will close this issue
Enable LADSPA plugins on MSVC #6758
Closed
6 tasks
@Rossmaxx
Copy link
Contributor

Close?

@DomClark
Copy link
Member

Close?

There's still GIG Player to go, but that was never in MSVC_INCOMPATIBLE_PLUGINS and is tracked in #3999, so yes, let's close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dan-giddins dan-giddins

Labels
compatibility windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable LADSPA plugins on MSVC Rossmaxx/lmms
3 participants
@DomClark @dan-giddins @Rossmaxx