Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when importing hydrogen song #5416

Closed
DragonForgedTheArtist opened this issue Mar 10, 2020 · 6 comments · Fixed by #5420
Closed

Crash when importing hydrogen song #5416

DragonForgedTheArtist opened this issue Mar 10, 2020 · 6 comments · Fixed by #5420
Labels

Comments

@DragonForgedTheArtist
Copy link
Contributor

Bug Summary

Attempt to import a Hydrogen song and lmms segfaults. In stable it reports that it is not a valid FL file and in git it reports that it is not a valid midi file.

Steps to reproduce

Open any hydrogen song. I have tried sever with the same results

Expected behavior

The song will import and either place the pattern in the beat editor or the song editor. Not sure which it's supposed to do.

Actual behavior

LMMS crashes and closes usually with a segfault

Affected LMMS versions

1.1.3 and above windows and linux

Logs

Click to expand
MidiImport::tryImport(): not a Standard MIDI file
Segmentation fault (core dumped)
@Spekular
Copy link
Member

Reproduced, sort of, on Win 10 with 1.2 and a master build. In my testing LMMS stopped responding rather than crashing, and I got a "no default soundfont" warning rather than "invalid midi file/fl project".

@musikBear
Copy link

ehrm.. wasent Hydrogen-file-usage dropped when FLs-files was dropped?
There are no import option hydrogen-files, only MIDI :?

@Spekular
Copy link
Member

@musikBear if you select File > Import, you'll find "Hydrogen Project" as an option in the file filter ("Files of type") dropdown. If hydrogen import was meant to be dropped then this option should be removed as well. I also question the ability to select "All files" as a filter.

@musikBear
Copy link

image
Holy .. farm-animal you are correct! @Spekular In both accounts
and yes that is wrong

@Spekular
Copy link
Member

plugins/HydrogenImport still exists on both 1.2 and master branch though, so I don't see that support would be dropped.

@zonkmachine
Copy link
Member

Fixed in #5420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants