Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triple Oscillator clicks if with phase shifting of 90 degrees #5119

Closed
JohannesLorenz opened this issue Aug 11, 2019 · 0 comments · Fixed by #5199
Closed

Triple Oscillator clicks if with phase shifting of 90 degrees #5119

JohannesLorenz opened this issue Aug 11, 2019 · 0 comments · Fixed by #5199
Labels

Comments

@JohannesLorenz
Copy link
Contributor

Select sine wave only, start at 90 "PO" (oscillator phase shift). Play a note (for lower note, you'll hear it best). Then 3Osc starts with a click.

Should this be fixed? If you have an attack time of > 0, there is no additional fade in algorithm required. But if your attack time is = 0, I think a fade-in algorithm must be applied.

For background info, zynaddsubfx uses S-formed envelopes for fade-in. The length depends on the note played, which results in a punchy, but not clicking sound for all frequencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant