-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VST pitch automation not working #4625
Comments
What VSTs have you tested this with? |
Take your pick of vst it doesn't appear to matter but you could try it on synth1. |
I've experienced this too. I haven't investigated too far, but I think it's caused by #4460. VST automation is currently sent to the plugin from the main thread, and if it's still holding the mutex to send the pitch event, audio processing is skipped for the plugin. I think my fix for #4543 should also fix this, as it changes VST automation to be sent from the processing thread. |
Thanks for the report, @Cangle50! |
Your Welcome SecondFlight |
I think so. However, I thought it wouldn't matter. See #4460 (comment) |
To musikBear if you can, try it in the 64 bit ver. that's the ver. I use. |
@Cangle50 |
@musikBear |
Ohhh so on a continuous note |
@musikBear On a side note to the Dev's. The crackling noise may not be limited to the automation of the pitch. |
@DomClark is this worth milestoning for the 1.2.0 branch, or is this a regression we'll have to live with on 1.2.0? Please classify and milestone appropriately. |
The automation can be fixed quite easily I think, I'll make a PR sometime soon. The keyboard scrubbing might be trickier. I'd like to make some changes to the IPC code on the master branch, outlined in #4540 (comment), which would probably fix it, but that's a future thing. |
After some thinking, now I think reverting #4460 is an overkill. I was able to hear the noise with manual changes as well, but it was quite slight. |
If you try to automate the pitch in vestige with a Automation track, it makes a nasty unacceptable crackling/static noise
this is on a Windows 10 OS PC.
The text was updated successfully, but these errors were encountered: