Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd behaviors when renaming the master mixer channel. #3861

Open
Sawuare opened this issue Oct 7, 2017 · 7 comments
Open

Odd behaviors when renaming the master mixer channel. #3861

Sawuare opened this issue Oct 7, 2017 · 7 comments

Comments

@Sawuare
Copy link
Member

Sawuare commented Oct 7, 2017

Windows 10 Pro, 64-bit OS.

GUI bugs. They happen most of the time.

They are present in RC.4, but not in master.

  • Bug 1:
    To reproduce:
  1. On the master mixer channel, double-click it or right-click it then select "Rename channel".
    The green border of the naming box isn't there.
    image
  2. Click anywhere in the mixer other than the channel itself.
  3. Do step 1 again then press enter.
    The name of the channel is highlighted in gray as if it was selected.
    image

While bug 1 is present in a project then opening a new project, the bug will be present in it.

This bug can't be undone unless LMMS is closed.

  • Bug 2:
    To reproduce:
  1. Add a mixer channel if there isn't one.
  2. Do step 1 in bug 1.
    The green border of the naming box isn't there, too.
  3. Click any mixer channel other than the master one.
    image

While bug 2 is present in a project then opening a new project, the name of the channel in the new project will be the same as the old project like this:
image

This bug can be undone by doing step 1 in bug 1, but this will result in bug 1.

@BaraMGB
Copy link
Contributor

BaraMGB commented Oct 7, 2017

I cannot reproduce these bugs. I have the green border by renaming. ( Windows 10, 64 bit RC4)

What I can see is: While renaming I click outside of LMMS the mixer channel looks like your second pic:

@musikBear
Copy link

win 32 rc4 -no error eg -cant reproduce

@Sawuare
Copy link
Member Author

Sawuare commented Oct 8, 2017

I forgot to mention my specs and that these bugs happen most of the time, but not always.
Updated the original comment.

@PhysSong
Copy link
Member

Confirmed step 3 of bug 1 on Ubuntu 18.04 beta. It can be fixed easily, by adding one line. I'll open a pull request for that soon.
Though I haven't tested other bugs on Windows, I can point out a possible reason for them. We use QLineEdit::editingFinished signal to detect the losing of focus of line edits. The signal should be emitted when a QLineEdit loses focus, but in the situation it seems not.

@PhysSong
Copy link
Member

@Sawuare Could you provide some additional information about your system? I don't know if it can help, but I want to know:

  • Language & Locale settings
  • IME settings
    I hope someone can work around this(maybe Qt bug?).

@Sawuare
Copy link
Member Author

Sawuare commented Apr 15, 2018

@PhysSong

image
Input method is the same as the Keyboard layout, so US and Arabic (101).

@PhysSong
Copy link
Member

PhysSong commented Jun 3, 2018

Issue was wrongly closed by GitHub. As I guessed in #4293, it looks like a Qt bug or something similar. I'm sure there's nothing wrong in LMMS. I'll close this after switching to newer version of Qt and fix confirmed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants