Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade method for broken sample paths #3533

Closed
lukas-w opened this issue May 6, 2017 · 3 comments
Closed

Upgrade method for broken sample paths #3533

lukas-w opened this issue May 6, 2017 · 3 comments
Labels
bug
Milestone
1.2.0

Comments

@lukas-w
Copy link
Member

lukas-w commented May 6, 2017

#1719 introduced a bug that made all sample paths being saved as absolute in project files (reported in #3491).

#3510 fixed the regression, but we should try to find a method to fix/relativize samples from existing projects since 1.2.0-rc2.
@lukas-w lukas-w added this to the 1.2.0 milestone May 6, 2017
@tresf
Copy link
Member

tresf commented May 7, 2017

Started the upgrade logic here tresf@08581c5, but something's broken. Can't get the debugs to fire. Second set of eyes appreciated.

@tresf tresf mentioned this issue May 7, 2017
Closed
@tresf
Copy link
Member

tresf commented May 7, 2017 •
edited
Loading

I had run into a self-inflicted snag checking for newer project versions. I'm glad I did... Although first instinct is to honor this logic, making samples relative can fix an annoyance occurred when the LMMS WORKING DIRECTORY is misconfigured. So I'm proposing to run this upgrade task on the load of each project regardless of version; thus it can't really be referred to as an "upgrade" task. PR available in #3540. Thoughts and testing welcome.

@tresf
Copy link
Member

tresf commented May 11, 2017

Fixed via #3510, we just didn't know it at the time. Explanation here: #3540 (comment)

@tresf tresf closed this as completed May 11, 2017
@tresf tresf mentioned this issue Oct 26, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

Fix non-relative samples tresf/lmms
3 participants
@lukas-w @Umcaruje @tresf