Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser Audio Preview and Metronome Sounds Are Affected By Mixer Effects #3186

Open
miketurn opened this issue Dec 28, 2016 · 7 comments
Open
Labels

Comments

@miketurn
Copy link
Contributor

miketurn commented Dec 28, 2016

When testing out version 1.2.0 RC1 I noticed when you have effects added to your mixer, audio such as the metronome ticking sound and audio previewing sounds from the browser are affected by those effects.
I notice this when I was messing around with an EQ by over exaggerating its settings and noticed that the sounds mentioned above were being altered because of it.
Also these are the two instances I have found but I would imagine any audio that is coming through the browser would be affected as well.
Overall this doesn't seem like it should be intentional, especially the metronome, the browser audio maybe.
Not sure if anyone else experiences this?
I can kind of see the browser reacting this way to let you know what the audio will sound like in your project, but might be nice to be able to turn this on and off.
(If this post should be split into two separate posts please let me know and I will fix it)

@karmux
Copy link
Contributor

karmux commented Dec 28, 2016

Currently all sounds go through master mixer channel and if master channel has effects then all sounds have them as well. To avoid file browser sounds from getting any effect they must skip master mixer channel somehow.

@BaraMGB
Copy link
Contributor

BaraMGB commented Dec 29, 2016

I would say that's a bug. Presets and metronome shouldn't be go through the master fx.

@ghost
Copy link

ghost commented Jan 8, 2017

i would say that's a bug

it's more a logic error but yeah

@Umcaruje Umcaruje added the bug label Jan 9, 2017
@Sawuare
Copy link
Member

Sawuare commented Jan 22, 2018

All LMMS audio should go through the master channel.
For previewing, master channel effects can be disabled by a simple click.

@musikBear
Copy link

@Sawuare nahh, you cant expect a newbe to realize that he need to disable master-chain FX-tab, it also really cumbersome and non-intuitive.
Perhaps it could be defended, that is the MyPreset sidebar was opened, Master channel was automatically without FX-train, but some kind of visual warning should be shown. It would also need an auto-shut, of the sidebar, if user press play... .. .

@rghvdberg
Copy link
Contributor

I think preview should bypass master completely. Same for metronome.

@SecondFlight
Copy link
Member

I may sound like a broken record to some people at this point, but FL doesn't do it. ™️

I think this could go either way. You may want to hear a preset through your mastering chain, but if your chain is aggressive then maybe you would want to hear it raw.

Now the metronome is something entirely different. I can 100% agree that the metronome shouldn't be going through the master channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants