LADSPA vinyl(VyNil) effect is broken

[musikBear]

OS : winXP sp3
LMMS: 1.1.90-g33d8v44

Issue description: User report this plugin broken. it will create strange beeb artefacts in various freq.

Recreate :
new project.
Insert 3oc default Bell.
insert LADSPA Vinyl-effect in instrument FX-tab
play a note

[DeRobyJ]

Confirmed on win7 and win8.1

[karmux]

I can reproduce this on Kubuntu Linux 16.10 but only with SDL. Vinyl and some other LADSPA issues vanish with ALSA for some reason.

[zonkmachine]

I've got the beeps but it's pretty intermittent.

The plugin generates some warnings of unititialized variable.

vynil_1905.xml:78:36: warning: variable 'click_buffer_omega' is uninitialized when used here [-Wuninitialized]

        plugin_data->click_buffer_omega = click_buffer_omega;

                                          ^~~~~~~~~~~~~~~~~~

vynil_1905.xml:237:2: note: variable 'click_buffer_omega' is declared here

        fixp16 click_buffer_omega;

        ^

vynil_1905.xml:79:34: warning: variable 'click_buffer_pos' is uninitialized when used here [-Wuninitialized]

        plugin_data->click_buffer_pos = click_buffer_pos;

                                        ^~~~~~~~~~~~~~~~

vynil_1905.xml:238:2: note: variable 'click_buffer_pos' is declared here

        fixp16 click_buffer_pos;

        ^

2 warnings generated.

[zonkmachine]

Demo project here: vynilnoise.mmp.zip
Turn the volume down.

[zonkmachine]

The 'beeps' seem to be unaffected by buffer size and sample quality and are square wave bursts at some fixed frequency depending on the effects settings and lasting about 35-50 ms. I think it could possibly be a filter driven into resonance by a sudden sound spike.

[zonkmachine]

It seem to be the Year setting that decides the frequency of the square wave burst.
Some settings will generate inf/NaN.

[VilhelmEnt]

If your problems are just beeping, it is because the effect is on a certain instrument. I fixed this problem by adding it as an effect for the overall effect bar

[lbfalvy]

If your problems are just beeping, it is because the effect is on a certain instrument. I fixed this problem by adding it as an effect for the overall effect bar

I have it on an effect chain that has only one instrument and still get the beeps. Does anyone know a workaround or another vinyl effect I could use that doesn't have this problem?

[afAtedg]

Hi,
Same problem for me, with vynil plugin on the master track.

My system :
Jack as audio server
Compiled LMMS Version 1.2.2 (Linux/x86_64, Qt 4.8.7, GCC 8.3.0)
on Debian Buster 64bit

edit : same thing with LMMS master Version 1.3.0-alpha.1.65+g4107bc02b (Linux/x86_64, Qt 5.11.3, GCC 8.3.0)

[ExperiBass]

Bumping, this still happens on master 1.3.0-alpha.1.144+g3d7ef9fa4 (Linux x86_64, Qt 5.15.2, GCC 11.1.0)

[Monospace-V]

This has made the demo project StrictProduction-DearJonDoe unusable half the time. I feel like I've encountered this somewhere else too, however, without VyNil.