From 090b5a775267e88b9862ea7e8051c0ccde531c52 Mon Sep 17 00:00:00 2001 From: Tres Finocchiaro Date: Wed, 28 Oct 2020 17:20:12 -0400 Subject: [PATCH] Fix DMG titles > 27 chars (#5741) Workaround upstream bug https://github.com/LinusU/node-appdmg/issues/48 --- cmake/apple/CMakeLists.txt | 5 +++++ cmake/apple/package_apple.json.in | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/cmake/apple/CMakeLists.txt b/cmake/apple/CMakeLists.txt index 835d886b9b6..0b66689e75d 100644 --- a/cmake/apple/CMakeLists.txt +++ b/cmake/apple/CMakeLists.txt @@ -9,6 +9,11 @@ SET(MACOSX_BUNDLE_MIMETYPE "application/x-lmms-project") SET(MACOSX_BUNDLE_MIMETYPE_ICON "project.icns") SET(MACOSX_BUNDLE_MIMETYPE_ID "io.lmms") SET(MACOSX_BUNDLE_PROJECT_URL "${PROJECT_URL}") +SET(MACOSX_BUNDLE_DMG_TITLE "${MACOSX_BUNDLE_BUNDLE_NAME} ${MACOSX_BUNDLE_LONG_VERSION_STRING}") + +# FIXME: appdmg won't allow volume names > 27 char +# See also https://github.com/LinusU/node-appdmg/issues/48 +STRING(SUBSTRING "${MACOSX_BUNDLE_DMG_TITLE}" 0 27 MACOSX_BUNDLE_DMG_TITLE) CONFIGURE_FILE("lmms.plist.in" "${CMAKE_BINARY_DIR}/Info.plist") CONFIGURE_FILE("install_apple.sh.in" "${CMAKE_BINARY_DIR}/install_apple.sh" @ONLY) diff --git a/cmake/apple/package_apple.json.in b/cmake/apple/package_apple.json.in index 1d1147cbf21..f6660b345bc 100644 --- a/cmake/apple/package_apple.json.in +++ b/cmake/apple/package_apple.json.in @@ -1,5 +1,5 @@ { - "title": "@MACOSX_BUNDLE_BUNDLE_NAME@ @MACOSX_BUNDLE_LONG_VERSION_STRING@", + "title": "@MACOSX_BUNDLE_DMG_TITLE@", "background": "@CMAKE_SOURCE_DIR@/cmake/apple/dmg_branding.png", "icon-size": 128, "contents": [