-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/newarch #561
Closed
Closed
Features/newarch #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… operating systems are set as class default_os
…namedtuple. Also added some TODO comments to later consider changing how architecture is handled
…d the way Platforms are compared. Created a mini inherited class named Arch that inherits from namedtuple. The reason for this is to override the namedtuple __str__ method to make arch tuples look prettier when printed out. Rather than Arch(platform= ... ) it prints to platform-os-target which makes directory paths to packages look cleaner.
… tuple architecture
…they weren't going to be used anyway
… and checks whether each piece of string is a valid platform, operating system and target. If the operating system or target are none it will use the defaults. Updated the documentation for that method. One thing that bothers me is how to account for the multitude of operating systems when cross compiling. If someone wants to compile with another operating system not found on current platform. How can spack check to see if it is valid?
… tuple so any time we need access to target we do architecture.target.
…ersion of the arch tuple
…instead of spec.target
…architecture.target.concrete
…thods are used my operating system subclasses
… platform dictionary
…piler strategy is set correctly
Add patch to compile pcre with Intel 16.0.3 compiler
Package serf also depends on zlib.
Make Boost an optional feature of Trilinos.
Add variant for boost graph and parallel graph
Add packages c-blosc and hdf5-blosc
Do not pass "/usr" or "/usr/local" as path to configure
This does two things: 1. By default `spack find` no longer shows variants. You have to supply `-v` to get that 2. This improves the `colify` implementation so that it no longer pads the rightmost column. This avoids the issue where if one spec was too long in the output, *all* specs would have space padding added to that width, and it would look like the output of `spack find` was double spaced. This no longer happens -- the one bad line wraps around and the other lines are now single-spaced when you use `-v` with boost.
Conflicts: lib/spack/spack/config.py var/spack/repos/builtin/packages/lua/package.py
… different operating systems we can grab the name correctly. This avoids having to worry whether we have a version attached to it or not.
This is merged with some rewritten commits for correcting emails. Thanks to Greg and Mario! |
See #1071 |
4 tasks
This was referenced Jun 25, 2016
11 tasks
matz-e
pushed a commit
to matz-e/spack
that referenced
this pull request
Apr 27, 2020
Update URLs to official ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed Cray port plus enhanced architecture support.
Major merge involved, I'll begin that work now.