fix for the shell arg handling issues #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setup-env.sh script now saves off the argument array before shifting off all the arguments so that the final command invocation doesn't arbitrarily requote the arguments. All external quoting is preserved now. This has been thoroughly tested with zsh, but should probably be tested with bash etc. before acceptance.
|
+1 Cannot reproduce the problem in bash or zsh with this branch. |
|
Thanks! |
tgamblin
added a commit
that referenced
this pull request
Dec 18, 2015
fix for the shell arg handling issues
matz-e
pushed a commit
to matz-e/spack
that referenced
this pull request
Jan 28, 2019
…#205) 0.4.1 was the patch for supporting both float and doubles Dropping old versions
climbfuji
added a commit
to climbfuji/spack
that referenced
this pull request
Dec 20, 2022
…ization release/1.2.0: bug fix for ecmwf-atlas with Intel etc
greenc-FNAL
pushed a commit
to greenc-FNAL/spack
that referenced
this pull request
Nov 21, 2023
tweaks from larsoft build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setup-env.sh script now saves off the argument array before shifting off
all the arguments so that the final command invocation doesn't arbitrarily
requote the arguments. All external quoting is preserved now. This has been
thoroughly tested with zsh, but should probably be tested with bash etc.
before acceptance.
fixes #204