Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalScriptAdapter shell definition in batch requires shebang and quotes #180

Closed
koning opened this issue Apr 16, 2019 · 1 comment
Closed
Assignees
Labels
bug Description of reproducible unexpected behavior. Good First Issue If you're looking to get involved, these are good places to start!

Comments

@koning
Copy link
Member

koning commented Apr 16, 2019

The current LocalScriptAdapter takes an argument that is the shell including the shebang, shell="#!/bin/bash". If a different shell is required, the shebang must be included when adding the the batch section. In yaml this means that the variable needs to be quoted or it will be interpreted as a comment:
shell: "#!/bin/tcsh"
not
shell = #!/bin/tcsh <-- comment, shell will be empty
Removing the #! requirement and adding this when the script is written will eliminate the quoting requirement.

@FrankD412 FrankD412 added the bug Description of reproducible unexpected behavior. label Apr 16, 2019
@FrankD412 FrankD412 added this to the Release v1.1.4 milestone Apr 16, 2019
@FrankD412 FrankD412 added the Good First Issue If you're looking to get involved, these are good places to start! label Apr 16, 2019
@FrankD412
Copy link
Member

Fixed by #181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Description of reproducible unexpected behavior. Good First Issue If you're looking to get involved, these are good places to start!
Projects
None yet
Development

No branches or pull requests

2 participants