Skip to content
This repository has been archived by the owner on May 15, 2022. It is now read-only.

Customize settings via webserver and command (settingsUpdate) #50

Open
emilianya opened this issue Dec 9, 2020 · 20 comments
Open

Customize settings via webserver and command (settingsUpdate) #50

emilianya opened this issue Dec 9, 2020 · 20 comments
Labels
commands Related to commands enhancement New feature or request priority: kinda important

Comments

@emilianya
Copy link
Contributor

This would make changing config much easier. There would be support for environments where editing local files isnt possible via storing the settings remotely. I am also considering an option to enable a webserver for changing the settings with nice little clicky switches instead of annoying commands!

@emilianya emilianya added enhancement New feature or request commands Related to commands priority: do when bored labels Dec 9, 2020
@emilianya emilianya self-assigned this Dec 9, 2020
@emilianya
Copy link
Contributor Author

This is mostly finished IN UNCOMMITTED CHANGES AAAAAAAAAAAAa:
Currently v!settings needs some slight polish
Webserver part is mostly finished, it only needs some logic and I need to get it to talk to the new config API correctly
Config API is done
I need to add an option to disable webserver into config.

@emilianya
Copy link
Contributor Author

This has taken much longer than expected

@emilianya
Copy link
Contributor Author

No progress in 18 days lmao i shoudl finish this

@emilianya
Copy link
Contributor Author

emilianya commented Mar 23, 2021

Problem List:

  1. when remoteSettings is false: config.js never writes the changed config
  2. when remoteSettings is false: config.js never reads the config as seen if you edit it manually
  3. when remoteSettings is true: config.js writes multiple thingies for it probably due to an oversight

@nyakase nyakase changed the title v!settings Customize settings via webserver and command Mar 23, 2021
@ProFireDev
Copy link
Contributor

Problem List:

  1. when remoteSettings is false: config.js never writes the changed config
  2. when remoteSettings is false: config.js never reads the config as seen if you edit it manually
  3. when remoteSettings is true: config.js writes multiple thingies for it probably due to an oversight

where did you guys get to yesterday? did you fix some of the other major issues?

@emilianya
Copy link
Contributor Author

Problem List:

  1. when remoteSettings is false: config.js never writes the changed config
  2. when remoteSettings is false: config.js never reads the config as seen if you edit it manually
  3. when remoteSettings is true: config.js writes multiple thingies for it probably due to an oversight

where did you guys get to yesterday? did you fix some of the other major issues?

I dont think we did anything

@emilianya emilianya changed the title Customize settings via webserver and command Customize settings via webserver and command (settingsUpdate) Mar 25, 2021
@ProFireDev
Copy link
Contributor

Lol I thought you did but maybe that was all front end stuff. It's getting there though

@emilianya
Copy link
Contributor Author

Lol I thought you did but maybe that was all front end stuff. It's getting there though

Yeah, it was all just faffing on with the 403 page and the buttons

@ProFireDev
Copy link
Contributor

Lol I thought you did but maybe that was all front end stuff. It's getting there though

Yeah, it was all just faffing on with the 403 page and the buttons

Oh that's not bad at all then. Basically prod ready maybe not quite lmao. There's some work left still

@emilianya
Copy link
Contributor Author

Lol I thought you did but maybe that was all front end stuff. It's getting there though

Yeah, it was all just faffing on with the 403 page and the buttons

Oh that's not bad at all then. Basically prod ready maybe not quite lmao. There's some work left still

I would much more rather getting the big issues done first, everything else is small tweaks

@ProFireDev
Copy link
Contributor

Lol I thought you did but maybe that was all front end stuff. It's getting there though

Yeah, it was all just faffing on with the 403 page and the buttons

Oh that's not bad at all then. Basically prod ready maybe not quite lmao. There's some work left still

I would much more rather getting the big issues done first, everything else is small tweaks

For sure, luckly there's not too many big things left to do

@emilianya
Copy link
Contributor Author

Lol I thought you did but maybe that was all front end stuff. It's getting there though

Yeah, it was all just faffing on with the 403 page and the buttons

Oh that's not bad at all then. Basically prod ready maybe not quite lmao. There's some work left still

I would much more rather getting the big issues done first, everything else is small tweaks

For sure, luckly there's not too many big things left to do

Well its the stuff i have no clue how to do, except 3.

@ProFireDev
Copy link
Contributor

Work on #3, then I'll take a look at the best and see what i can do. But google is your friend here. Or maybe even ask a question on stack overflow. But I got lots of free time coming up, so I'll do my best to look into it

@ProFireDev
Copy link
Contributor

Work on #3, then I'll take a look at the best and see what i can do. But google is your friend here. Or maybe even ask a question on stack overflow. But I got lots of free time coming up, so I'll do my best to look into it

But just yolo and figure it out as you go I guess lmao.

That's the best way to learn, and we can go back and fix it later

@emilianya
Copy link
Contributor Author

Work on #3, then I'll take a look at the best and see what i can do. But google is your friend here. Or maybe even ask a question on stack overflow. But I got lots of free time coming up, so I'll do my best to look into it

But just yolo and figure it out as you go I guess lmao.

That's the best way to learn, and we can go back and fix it later

Wel a 9 year old stackoverflow solution let me down so kinda 😔

@ProFireDev
Copy link
Contributor

Work on #3, then I'll take a look at the best and see what i can do. But google is your friend here. Or maybe even ask a question on stack overflow. But I got lots of free time coming up, so I'll do my best to look into it

But just yolo and figure it out as you go I guess lmao.
That's the best way to learn, and we can go back and fix it later

Wel a 9 year old stackoverflow solution let me down so kinda 😔

lmao of Couse it did, smh at least you didn't find marked as duplicate or stupid question as the answer XD

@emilianya
Copy link
Contributor Author

At this point I would like to leave a message here:
NodeJS on my machine became very drunk and it thinks files contain stuff they dont.
I am unable to work on this

@ProFireDev
Copy link
Contributor

At this point I would like to leave a message here:
NodeJS on my machine became very drunk and it thinks files contain stuff they dont.
I am unable to work on this

time to reinstall or something, weird

@nyakase
Copy link
Member

nyakase commented Apr 19, 2021

priority: do when bored

@ProFireDev
Copy link
Contributor

priority: do when bored

it might be a good idea to bump it up to high.... its one of the last things left

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
commands Related to commands enhancement New feature or request priority: kinda important
Projects
None yet
Development

No branches or pull requests

3 participants