Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entry editor: Toggle journal abbreviation roundtrip does not work #5

Open
2 tasks done
LDeolindo opened this issue Dec 1, 2022 · 0 comments
Open
2 tasks done
Labels
bug Something isn't working entry-editor good first issue Good for newcomers

Comments

@LDeolindo
Copy link
Owner

JabRef version

Latest development branch build (please note build date below)

Operating system

macOS

Details on version and operating system

mac os 11.7 big sur

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Create a new article, set journal or journaltitle to Comm. Pure Appl. Math.
  2. Click on the Toggle abbreviation button next to the field
    image
  3. A dotless abbreviation is now in the field (Medline abbrev)
  4. The field now shows Comm Pure Appl Math
  5. Click again on the Toggle abbrevation button.
  6. Nothing happens

=> Here the full journal name should be visible

Hints on the code

For anyone looking into this:
The problem is that both methods isKnownName
and

jabref/buildSrc/src/copied/java/org/jabref/logic/journals/JournalAbbreviationRepository.java

Line 77 in a1f2d51

77 public Optional<Abbreviation> get(String input) { 

do not consider a dotless abbreviation.

Solution could be to replace spaces with dots before checking.

Appendix

...

Log File
Paste an excerpt of your log file here
@LDeolindo LDeolindo added bug Something isn't working good first issue Good for newcomers entry-editor labels Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working entry-editor good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant